-
Notifications
You must be signed in to change notification settings - Fork 472
docs: remove v19.2 references from Jekyll data files #20069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ebembi-crdb
commented
Aug 5, 2025
- Remove v19.2 entries from _data/redirects.yml version arrays
- Replace v19.2 release blocks in _data/releases.yml with single lines
- Cleanup to remove archived version from documentation site
- Remove v19.2 entries from _data/redirects.yml version arrays - Replace v19.2 release blocks in _data/releases.yml with single lines - Cleanup to remove archived version from documentation site
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebembi-crdb from the build log it looks like you need to fix two broken links pointing to stuff in 19.2 that will no longer exist
otherwise we're on the right track! thanks for working on this!
once the build is green please re-request review and i'll look again ASAP!
1:59:57 AM: htmltest started at 05:59:57 on _site
1:59:57 AM: ========================================================================
1:59:58 AM: running in concurrent mode, this is experimental
2:00:08 AM: docs/releases/v19.2.html
2:00:08 AM: hash does not exist --- docs/releases/v19.2.html --> #v19-2-0
2:00:08 AM: docs/releases/cloud.html
2:00:08 AM: hash does not exist --- docs/releases/cloud.html --> /docs/releases/v19.2.html#v19-2-4
2:00:09 AM: ========================================================================
2:00:09 AM: ✘✘✘ failed in 11.877152545s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Eeshan!!!!! PSYCHED!!!! Let's archive more of these ASAP :-)
PS a lot of your changes were necessary because we still need https://cockroachlabs.atlassian.net/browse/DOC-14152 If we can do some kind of linting / validation on image versions that would be a nice feature (i'll also drop a comment there) |