Skip to content

Disable legacy 'harmony' option from uglifier_args #20178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmloveland
Copy link
Contributor

Fixes EDUENG-112

This patch eliminates the deprecated Uglifier warnings and improves build performance without affecting functionality.

Fixes EDUENG-112

This patch eliminates the deprecated Uglifier warnings and improves
build performance without affecting functionality.
@rmloveland rmloveland requested a review from ebembi-crdb August 21, 2025 15:32
Copy link

Files changed:

  • src/api/_config_base.yml
  • src/current/_config_base.yml
  • src/interactive-tutorials/_config_base.yml

Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for cockroachdb-api-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 7cb6148
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/68a73c1e577e7e0008158608

Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 7cb6148
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/68a73c1e0cf7950008b33235

Copy link

netlify bot commented Aug 21, 2025

Netlify Preview

Name Link
🔨 Latest commit 7cb6148
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/68a73c1e29b6ba0008bd8b3f
😎 Deploy Preview https://deploy-preview-20178--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@ebembi-crdb ebembi-crdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rmloveland
Copy link
Contributor Author

@ebembi-crdb looks like cockroachdb-api-docs and cockroachdb-interactive-tutorials-docs are broken. Should I modify this PR to only change the value in src/current/_config_base.yml and leave the other things alone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants