You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@smcvey@fqazi I hope this captures the nuance of which versions of CRDB are effected and under which conditions, please let me know if add'l changes are needed!
@rmloveland I think it's because auto_commit_before_ddl is enabled by default on those releases. But users can also toggle it off on later releases, which this message covers. @smcvey Do you have any thoughts on this?
We have had some customers switching off auto_commit_before_ddl after upgrading and discovering it had changed - it was breaking their schema changing tools so I think including it in later versions of the docs should still happen, but mention that only if auto_commit_before_ddl is disabled.
We have had some customers switching off auto_commit_before_ddl after upgrading and discovering it had changed - it was breaking their schema changing tools so I think including it in later versions of the docs should still happen, but mention that only if auto_commit_before_ddl is disabled.
ah ok thanks for that info @smcvey ! I have updated the v25.1 and later docs with the following in this commit:
However, if the schema change with column backfill runs inside an [explicit transaction]({% link {{ page.version.version }}/begin-transaction.md %}) and the [autocommit_before_ddl session setting]({% link {{page.version.version}}/set-vars.md %}#autocommit-before-ddl) is disabled, it will emit the entire table to the changefeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DOC-15563