Conversation
taroface
requested review from
Jeremyyang920,
crash-overdrive,
rohan-joshi and
ryanluu12345
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Deploy Preview for cockroachdb-docs canceled.
|
ryanluu12345
left a comment
ryanluu12345
left a comment
There was a problem hiding this comment.
The content and layout look great! I think it's a really clean doc and intuitive. I left some comments just so Shashwat can clarify a few discrepancies I noted.
Regarding the layout, I don't think you need to show the "Staging" section for MySQL, Oracle, and PG sources. Staging is really only relevant for Cockroach sources. Can probably add conditional logic there. Other than that, sections look right to me.
florence-crl
left a comment
florence-crl
left a comment
There was a problem hiding this comment.
lgtm pending suggestions
| - Interpretation: High values indicate target apply cannot keep up with incoming transactions. | ||
| - `target_apply_queue_utilization_percent` | ||
| - Description: Percentage of apply queue capacity utilization. | ||
| - Interpretation: Values above 90 percent indicate severe backpressure. Increase [`--targetApplyQueueSize`]({% link molt/replicator-flags.md %}#target-apply-queue-size) or investigate target database performance. |
There was a problem hiding this comment.
Should this flag link be displayed for MySQL and Oracle, since "This flag applies only to CockroachDB and PostgreSQL (pglogical) sources"?
There was a problem hiding this comment.
@crash-overdrive @ryanluu12345 Florence raised a really good point -- does the --targetApplyQueueSize only apply to CRDB and PG sources? If so, I need to clarify here.
There was a problem hiding this comment.
it is applicable to Oracle
it is not applicable to MySQL.
There was a problem hiding this comment.
Shashwat is right. Only CRDB, PG, and Oracle. MySQL upcoming.
There was a problem hiding this comment.
Its only PG and Oracle. CRDB supports it too (with pebble stager) but we dont expose pebble stager publicly as of yet. So for now lets just mention PG and Oracle @taroface !
There was a problem hiding this comment.
Good catch Shashwat! That's an oversight on my end, my mistake! Sorry @taroface
There was a problem hiding this comment.
Just to confirm, we're talking about the --targetApplyQueueSize flag and not the target_apply_queue_size metric, right?
crash-overdrive
left a comment
crash-overdrive
left a comment
There was a problem hiding this comment.
LGTM mod minor things!
Can we update the metric mutations_total to mutation_total and also add it to the Oracle section as oracle supports this metric as well!
Also can we move the Note for Checkpoint terminology to CRDB section only instead of all the sections? Also for some reason staging has the Note for Checkpoint terminology as well, dont know if thats intentional or not!
Co-authored-by: Florence Morris <58752716+florence-crl@users.noreply.github.com>
…ize to flags table
taroface
force-pushed
the
molt-replicator-metrics
branch
from
710f1cf to
df6e8e5
Compare
5 participants
DOC-15229