Allow user to delete job pod on completion #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekdwivedi3060
suggested changes
Feb 16, 2022
| annotations: {} | ||
|
|
||
| # If true init job is deleted when completed. If false the job stays in complete status. | ||
| deleteJobOnCompletion: true |
There was a problem hiding this comment.
Would be better if we rename it to something helm hook related like enable-delete-hook
Comment on lines
+23
to
+27
| {{- if .Values.init.deleteJobOnCompletion }} | ||
| helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded | ||
| {{- else }} | ||
| helm.sh/hook-delete-policy: before-hook-creation | ||
| {{- end }} |
There was a problem hiding this comment.
We can keep this deletion behaviour as default one and add an option in values.yaml to disable this
|
@EnriqueLop Would you like to revive this PR. Please address the mentioned comments and rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New parameter in init object that allow user to automatically delete init job pod when complete.