Skip to content

Conversation

m-rcl
Copy link
Contributor

@m-rcl m-rcl commented Apr 11, 2024

as stated in #24 it's not possible to use networkPolicies with custom grpc rules.
PR #297 seems to be stale and the proposed solution renders strangely for the default of grpc (empty array).

This PR renders

networkPolicy:
  enabled: true
  ingress:
    grpc:
    - podSelector:
        matchLabels:
          app.kubernetes.io/instance: foo

into

[...]
  ingress:
    - ports:
        - port: grpc
      from:
        # Allow connections via custom rules.
        - podSelector:
            matchLabels:
              app.kubernetes.io/instance: foo
        # Allow client connection via pre-considered label.
        - podSelector:
            matchLabels:
[...]

and

networkPolicy:
  enabled: true
# leave grpc as empty array

into

[...]
  ingress:
    - ports:
        - port: grpc
      from:
        # Allow client connection via pre-considered label.
        - podSelector:
            matchLabels:
[...]

@rail rail requested a review from prafull01 April 16, 2024 11:13
@m-rcl
Copy link
Contributor Author

m-rcl commented Jun 18, 2024

Hi @prafull01, any chance we might get this merged soon?

@m-rcl
Copy link
Contributor Author

m-rcl commented Aug 5, 2024

Hi @rail, is there anyone else who might have a look at this PR?

@m-rcl
Copy link
Contributor Author

m-rcl commented Sep 12, 2024

@rail @prafull01 - any update?

@m-rcl
Copy link
Contributor Author

m-rcl commented Oct 31, 2024

@rail @prafull01 - This is still an issue with the lastest 14.0.5 chart. Any chance we might get this minor fix solved soon?
@udnay - Maybe you could have a look?

@m-rcl m-rcl changed the title Move template calls out of networkPolicy.ingress.grpc scope Fix: NetworkPolicies for custom grpc rules Nov 6, 2024
@m-rcl
Copy link
Contributor Author

m-rcl commented Mar 11, 2025

@rail @prafull01 - Can we please have this reviewed? It's pending for almost a year now

@prafull01 prafull01 merged commit f39e111 into cockroachdb:master Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants