[DRAFT] feat!: do not invalidate data block if bloomfilter returns false #4825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not invalidate data block if bloom filter returns false in SeekPrefixGE()
This is a DRAFT.
I don't get it why this proposal is beneficial 🤔. If I understand it correctly, the only valid operation after a successful
SeekPrefixGE()isNext(). Now, if the prefix is definitely not in the block, Next() is then not a meaningful operation before another seek is called. What's the point to keep the data block around?Also how do we prevent caller from calling Next() as mentioned in the comment? I must have missed something... 😕
concerns: #4788