Skip to content

[DNR] [WIP] db: introduce span policy enforcer#5735

Draft
xinhaoz wants to merge 4 commits intocockroachdb:masterfrom
xinhaoz:span-policy-enforcer
Draft

[DNR] [WIP] db: introduce span policy enforcer#5735
xinhaoz wants to merge 4 commits intocockroachdb:masterfrom
xinhaoz:span-policy-enforcer

Conversation

@xinhaoz
Copy link
Contributor

@xinhaoz xinhaoz commented Jan 20, 2026

No description provided.

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jan 20, 2026

This change is Reviewable

@xinhaoz xinhaoz changed the title db: introduce span policy enforcer [DNR] [WIP] db: introduce span policy enforcer Jan 20, 2026
@xinhaoz xinhaoz force-pushed the span-policy-enforcer branch from a08918c to 6320ca1 Compare January 20, 2026 20:43
@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@xinhaoz xinhaoz force-pushed the span-policy-enforcer branch from 6320ca1 to 4a06982 Compare January 20, 2026 21:26
@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@xinhaoz xinhaoz force-pushed the span-policy-enforcer branch 2 times, most recently from d8fcfbd to e5a68a1 Compare January 21, 2026 16:44
@github-actions
Copy link

github-actions bot commented Jan 21, 2026

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@xinhaoz xinhaoz force-pushed the span-policy-enforcer branch 2 times, most recently from db3afe5 to 532093f Compare January 21, 2026 22:08
@github-actions
Copy link

github-actions bot commented Jan 21, 2026

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@xinhaoz xinhaoz force-pushed the span-policy-enforcer branch from 532093f to 47ae8c1 Compare January 22, 2026 21:59
@github-actions
Copy link

github-actions bot commented Jan 22, 2026

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@xinhaoz xinhaoz force-pushed the span-policy-enforcer branch from 47ae8c1 to 2f4ff3d Compare January 26, 2026 20:53
@github-actions
Copy link

github-actions bot commented Jan 26, 2026

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@xinhaoz xinhaoz force-pushed the span-policy-enforcer branch from 2f4ff3d to cdb67ff Compare January 27, 2026 19:04
@github-actions
Copy link

github-actions bot commented Jan 27, 2026

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@xinhaoz xinhaoz force-pushed the span-policy-enforcer branch from cdb67ff to d2bbe87 Compare January 27, 2026 19:35
@github-actions
Copy link

github-actions bot commented Jan 27, 2026

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@xinhaoz xinhaoz force-pushed the span-policy-enforcer branch from d2bbe87 to 7aadbd4 Compare January 28, 2026 16:48
@xinhaoz xinhaoz force-pushed the span-policy-enforcer branch from 7aadbd4 to af8844c Compare February 11, 2026 21:13
@xinhaoz
manifest: add NextFile functions to ScanCursor
d53ca3f 
Add NextFile function to ScanCursor, which returns the first file after the
cursor position.
@xinhaoz
db: add span policy enforcer background goroutine
6e071ac 
Add a background span policy enforcer that scans the LSM to detect files
violating compression policies and marks them for policy enforcement compaction
(a new compaction type that will be introduced in a later commit).

Currently disabled by default, this initial implementation scans at a rate of
1 file per second, and checks only for a violation on the compression settings
in the span policy.

Part of: cockroachdb#5657
@xinhaoz xinhaoz force-pushed the span-policy-enforcer branch from af8844c to 2d29ad0 Compare February 18, 2026 18:46
@github-actions
Copy link

github-actions bot commented Feb 18, 2026

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@xinhaoz
db: add policy enforcement compaction infrastructure
f5421ca 
Add new policy enforcement compaction type which rewrites files to comply with
updated span policies (e.g., compression settings).
@xinhaoz
db: datadriven testing for span policy enforcer
1e92b86
@xinhaoz xinhaoz force-pushed the span-policy-enforcer branch from 2d29ad0 to 1e92b86 Compare February 18, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

O-AI-Review-Potential-Issue-Detected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xinhaoz @cockroach-teamcity