internal/keyspan: improve assertion failure panics#5763
Open
jbowens wants to merge 1 commit intocockroachdb:masterfrom
Open
internal/keyspan: improve assertion failure panics#5763jbowens wants to merge 1 commit intocockroachdb:masterfrom
jbowens wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Include keys within assertion failure panics when relevant, and use errors.AssertionFailedf.
Member
|
This change is |
xxmplus
approved these changes
Feb 4, 2026
Contributor
xxmplus
left a comment
xxmplus
left a comment
There was a problem hiding this comment.
@xxmplus made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include keys within assertion failure panics when relevant, and use errors.AssertionFailedf.