-
Notifications
You must be signed in to change notification settings - Fork 174
feat(convert): support explicit type hints in engine value encoding #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badmonster0
reviewed
Jul 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking care of this, @lemorage!
badmonster0
reviewed
Jul 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for starting this deep refactoring, which solves the problem more systematically!
badmonster0
reviewed
Jul 31, 2025
badmonster0
reviewed
Aug 1, 2025
badmonster0
reviewed
Aug 8, 2025
badmonster0
reviewed
Aug 11, 2025
badmonster0
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#792 (comment)
Cause
The problem was that
encode_engine_value
couldn't distinguish between:Solution
Makeencode_engine_value
function context-aware by adding an optional_in_struct
andtype_hint
params.The logic now:- When encoding struct fields, if the type-hint denotes it is a JSON, it stays what it is, otherwise becomes [] (assuming KTable)- When encoding standalone values (_in_struct=False): empty dicts stay {}Pass type hints when calling
encode_engine_value
function, so it will be explicitly known how we handle each value.