Skip to content

fix(ci): do not set --verbose by default #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025

Conversation

matejchalk
Copy link
Collaborator

Part of an effort to avoid extra CLI arguments which restrict cache reuse in Nx monorepos (related to #1040).

The --verbose flag was being set by default, which was probably an unintended consequence of #952. Tweaked the logic so that only explicitly setting debug: true or silent: false enables verbosity.

Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 0cbfaa3 with previous commit 25ad63e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 44 🔴 32 ↓ −12.5
Code coverage 🟢 90 🟢 90 ↑ +0.1
Security 🔴 0 🔴 0
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 4 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 44 🔴 32 ↓ −12.5
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Reduce unused CSS 🟥 Potential savings of 59 KiB 🟨 Potential savings of 59 KiB ↓ −100 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 4.8 s ↑ +52.3 %
Lighthouse Largest Contentful Paint 🟥 4.2 s 🟥 5.7 s ↑ +36.5 %
Lighthouse Speed Index 🟥 6.9 s 🟥 9.6 s ↑ +39.4 %
Lighthouse Time to Interactive 🟥 15.1 s 🟥 17.5 s ↑ +15.8 %
Code coverage Branch coverage 🟨 85.8 % 🟨 85.8 % ↑ +0.1 %
Code coverage Line coverage 🟨 86.8 % 🟨 86.8 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,990 KiB 🟩 Total size was 2,005 KiB ↑ +0.7 %
Lighthouse Minimizes main-thread work 🟥 18.8 s 🟥 24.0 s ↑ +27.5 %
Lighthouse Total Blocking Time 🟥 4,620 ms 🟥 7,080 ms ↑ +53.1 %
Lighthouse JavaScript execution time 🟥 8.7 s 🟥 11.1 s ↑ +27.9 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +15.8 %
Lighthouse Server Backend Latencies 🟩 120 ms 🟩 1,430 ms ↑ +1103.5 %
Lighthouse Max Potential First Input Delay 🟥 2,200 ms 🟥 3,200 ms ↑ +45.6 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 360 ms 🟩 Root document took 590 ms ↑ +65.7 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 90 ms ↑ +375.1 %

588 other audits are unchanged.

@matejchalk matejchalk force-pushed the no-verbose-in-ci-by-default branch from ea81bb3 to 612f0fc Compare July 30, 2025 15:55
@matejchalk matejchalk merged commit ab39b05 into main Jul 30, 2025
26 of 28 checks passed
@matejchalk matejchalk deleted the no-verbose-in-ci-by-default branch July 30, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants