Skip to content

feat(plugin-axe): add authentication support via setup script #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hanna-skryl wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(plugin-axe): add authentication support via setup script #1198

hanna-skryl wants to merge 5 commits into from
+491 −177

Conversation

@hanna-skryl
Copy link
Collaborator

@hanna-skryl hanna-skryl commented Dec 29, 2025 •
edited
Loading

Closes #1135

  • Add setupScript option for testing login-protected pages
  • Refactor browser management from standalone functions to AxeRunner class for cleaner lifecycle handling
  • Update Zod to v4.2.1 across all packages. This was required because Zod v4.1.5 fixed the z.function() type inference, which is now used for validating the setup function signature.
  • Refactor docsUrlSchema for Zod v4 compatibility
  • Test with a real Angular application behind username/password authentication

@hanna-skryl hanna-skryl self-assigned this Dec 29, 2025
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 models 🛠️ tooling 🧩 axe-plugin labels Dec 29, 2025
@nx-cloud
Copy link

nx-cloud bot commented Dec 29, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 2cadf0e

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 27s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 28s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-07 15:16:26 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 29, 2025 •
edited
Loading

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1198

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1198

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1198

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1198

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1198

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1198

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1198

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1198

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1198

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1198

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1198

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1198

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1198

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1198

commit: 2cadf0e

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 617feb4 with previous commit 9d4a223.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 36 🔴 40 ↑ +3.9
Code coverage 🟢 91 🟢 91 ↓ −0.1
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Performance 🔴 34 🔴 34 ↓ −0.1
Code style 🟢 99 🟢 99 –
Security 🟡 51 🟡 51 –
Updates 🟡 79 🟡 79 –
Type Safety 🟡 67 🟡 67 –
Miscellaneous 🟡 67 🟡 67 –
Accessibility 🟢 92 🟢 92 –
Best Practices 🟢 100 🟢 100 –
SEO 🟢 92 🟢 92 –
👍 1 group improved, 👎 2 groups regressed, 👍 7 audits improved, 👎 5 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 36 🔴 40 ↑ +3.9
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1
Lighthouse Performance 🔴 34 🔴 34 ↓ −0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Methods coverage 🟨 8 undocumented methods 🟨 8 undocumented methods +0 %
JSDocs coverage Classes coverage 🟥 6 undocumented classes 🟥 6 undocumented classes +0 %
Lighthouse Speed Index 🟥 7.4 s 🟥 7.9 s ↑ +6.2 %
Lighthouse Time to Interactive 🟥 13.7 s 🟥 14.6 s ↑ +7.1 %
JSDocs coverage Variables coverage 🟥 265 undocumented variables 🟥 258 undocumented variables ↓ −2.6 %
Lighthouse First Contentful Paint 🟥 3.3 s 🟥 3.3 s ↓ −2.4 %
JSDocs coverage Functions coverage 🟥 587 undocumented functions 🟥 573 undocumented functions ↓ −2.4 %
Lighthouse Total Blocking Time 🟥 1,950 ms 🟥 1,840 ms ↓ −5.4 %
Code coverage Line coverage 🟨 87 % 🟨 86.9 % ↓ −0.2 %
JSDocs coverage Types coverage 🟥 246 undocumented types 🟥 247 undocumented types ↑ +0.4 %
Code coverage Branch coverage 🟨 87.3 % 🟨 87.3 % ↓ −0.1 %
Code coverage Function coverage 🟩 94 % 🟩 94 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,120 KiB 🟩 Total size was 2,173 KiB ↑ +2.5 %
Lighthouse Minimizes main-thread work 🟥 10.7 s 🟥 9.8 s ↓ −9.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +7.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↓ −0.1 %
Lighthouse JavaScript execution time 🟥 5.2 s 🟥 4.9 s ↓ −5.5 %
Lighthouse Largest Contentful Paint 🟥 12.2 s 🟥 12.1 s ↓ −1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 219 KiB 🟥 Potential savings of 225 KiB ↓ −8.6 %
Lighthouse Server Backend Latencies 🟩 1,350 ms 🟩 1,290 ms ↓ −5 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 95 KiB 🟥 Potential savings of 95 KiB ↓ −10 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 106 KiB 🟥 Potential savings of 106 KiB ↓ −10 %
Lighthouse Initial server response time was short 🟥 Root document took 720 ms 🟥 Root document took 680 ms ↓ −5.7 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 70 ms ↑ +44.2 %
Lighthouse Max Potential First Input Delay 🟥 1,210 ms 🟥 1,220 ms ↑ +0.7 %
JSDocs coverage Properties coverage 🟥 16 undocumented properties 🟥 19 undocumented properties ↑ +18.8 %

653 other audits are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 617feb4 with previous commit 9d4a223.

💼 Project plugin-axe

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 68 🟡 70 ↑ +2.3
Code coverage 🟢 93 🟢 93 ↓ −0.3

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 3 audits regressed, 1 audit changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🟡 68 🟡 70 ↑ +2.3
Code coverage Code coverage metrics 🟢 93 🟢 93 ↓ −0.3

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Properties coverage 🟩 0 undocumented properties 🟥 3 undocumented properties ↑ +∞ %
JSDocs coverage Functions coverage 🟥 24 undocumented functions 🟨 10 undocumented functions ↓ −58.3 %
JSDocs coverage Variables coverage 🟥 19 undocumented variables 🟥 12 undocumented variables ↓ −36.8 %
Code coverage Line coverage 🟨 69.7 % 🟨 68.6 % ↓ −1.6 %
Code coverage Branch coverage 🟨 86.3 % 🟨 85.6 % ↓ −0.9 %
JSDocs coverage Types coverage 🟥 8 undocumented types 🟥 9 undocumented types ↑ +12.5 %

437 other audits are unchanged.

💼 Project models

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 93 🟢 93 ↓ −0.1

3 other categories are unchanged.

👎 1 group regressed, 👎 2 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 93 🟢 93 ↓ −0.1

11 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟩 91.5 % 🟩 91.4 % ↓ −0.1 %
Code coverage Line coverage 🟩 97.2 % 🟩 97.2 % ↓ −0.1 %

435 other audits are unchanged.

12 other projects are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review December 30, 2025 00:04
BioPhoton
BioPhoton approved these changes Jan 5, 2026
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestion to reduce lines in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BioPhoton BioPhoton BioPhoton approved these changes

@matejchalk matejchalk Awaiting requested review from matejchalk matejchalk is a code owner

Assignees

@hanna-skryl hanna-skryl

Labels

🧩 axe-plugin 🧩 eslint-plugin 🧩 models 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Axe Plugin - Authentication Support

3 participants

@hanna-skryl @BioPhoton