Skip to content

Conversation

TropicolX
Copy link
Contributor

@TropicolX TropicolX commented Oct 1, 2025

Updated the description of the handshake process for clarity and consistency. Adjusted the format and details of the commands received by the master.


Note

Clarifies the master-side replication handshake docs with a concise step list and updated test command expectations.

  • Documentation:
    • Handshake (Recap):
      • Reframes content from the master's perspective and renames section to Handshake (Recap).
      • Clarifies steps as a numbered list: PING, two REPLCONF, then PSYNC; notes PING needs no changes.
      • Specifies responding +OK\r\n to both REPLCONF commands; adds reference to RESP simple strings.
    • Tests:
      • Rewords and formats the command sequence and expected responses (PING, REPLCONF listening-port, REPLCONF capa psync2).

Written by Cursor Bugbot for commit 9310d04. This will update automatically on new commits. Configure here.

Updated the description of the handshake process for clarity and consistency. Adjusted the format and details of the commands received by the master.
@TropicolX TropicolX merged commit 2ab62b8 into main Oct 3, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant