TBE-198: limit number of login sessions with MeF #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of threads to control concurrency of webhook callback jobs
There was a problem hiding this comment.
I am curious how you landed on 15 rather than 10 or 20?
There was a problem hiding this comment.
The existing value was 5, and I figured that (if I want all connection attempts to succeed immediately) I'm adding 10 new possible threads that might need a DB connection (5 single-threaded workers for the MeF jobs, 1 5-threaded worker for the callbacks).
I'm not actually sure of myself here (maybe the webhook callback worker actually only needs one db connection, since the job doesn't use the db and therefore the only need is for the worker to claim & execute jobs?) but that was my reasoning, faulty or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use number of workers to control concurrency of mef jobs, and number of threads to control concurrency of webhook callback jobs