Skip to content

Update profile creation to set Profile all at once at the beginning of the process #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update profile creation to set Profile all at once at the beginning of the process #1810

wants to merge 1 commit into from

Conversation

kiminkim724
Copy link
Collaborator

Summary

To help #1768 work properly

  • Moves all the profile setting calls to one place so that onCreate, the code will have all the details it needs to populate the email.
  • Tested with the new functions in place, and the emails are populating the details correctly.

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.

Screenshots

Known issues

  • Don't know if this might break with the current firebase objects, so we'll have to see

Steps to test/reproduce

  1. Create an organization profile
  2. See if the data is populated correctly.

@vercel Vercel
Copy link

vercel bot commented May 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 11:24pm
maple-prod 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 6, 2025 11:24pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashamaryl sashamaryl Awaiting requested review from sashamaryl sashamaryl is a code owner

@mertbagt mertbagt Awaiting requested review from mertbagt mertbagt is a code owner

@nesanders nesanders Awaiting requested review from nesanders nesanders is a code owner

@mvictor55 mvictor55 Awaiting requested review from mvictor55 mvictor55 is a code owner

@timblais timblais Awaiting requested review from timblais timblais is a code owner

@alexjball alexjball Awaiting requested review from alexjball alexjball is a code owner

@Mephistic Mephistic Awaiting requested review from Mephistic Mephistic is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kiminkim724