Skip to content

extract translate-able strings -- Attachment component #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025

Conversation

jicruz96
Copy link
Collaborator

@jicruz96 jicruz96 commented Aug 7, 2025

Summary

Extracts translate-able strings from the components/CommentModal/Attachment.tsx.

Checklist

  • On the frontend, I've made my strings translate-able.
  • [n/a] If I've added shared components, I've added a storybook story.
  • [n/a] I've made pages responsive and look good on mobile.

Screenshots

Left is mapletestimony.org | Right is this branch.

Screenshot 2025-08-07 at 2 26 19 AM Screenshot 2025-08-07 at 2 24 06 AM Screenshot 2025-08-07 at 2 23 32 AM Screenshot 2025-08-07 at 2 26 49 AM

Steps to test/reproduce

  1. Sign up/Sign in
  2. Try to write testimony for a bill (this url that oughta take you straight to that page /submit-testimony?billId=H282&court=194&step=write)
  3. Confirm text in Attachment area looks the same as prod.
  4. Upload a file with your testimony. Confirm text looks the same as prod.
  5. Remove the file. Confirm text in Alert looks the same as prod.
  6. Upload a file >10MB. Confirm error message looks same as prod.

Copy link

vercel bot commented Aug 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 6:39am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
maple-prod ⬜️ Ignored (Inspect) Aug 7, 2025 6:39am

Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mertbagt mertbagt merged commit 3674643 into codeforboston:main Aug 12, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants