Skip to content

feat: add abac rules for products, environments, and promotion flows #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2024
Merged

feat: add abac rules for products, environments, and promotion flows #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9ba155
feat: add abac rules for products, environments, and promotion flows
danielm-codefresh Aug 31, 2024
341f8c0
run make docs
danielm-codefresh Sep 3, 2024
837e139
add tests
danielm-codefresh Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions codefresh/resource_abac_rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
)

var validSetValues = []string{"REFRESH", "SYNC", "TERMINATE_SYNC", "VIEW_POD_LOGS", "APP_ROLLBACK"}
var validSetValues = []string{"REFRESH", "SYNC", "TERMINATE_SYNC", "VIEW_POD_LOGS", "APP_ROLLBACK", "TRIGGER_PROMOTION", "RETRY_RELEASE", "PROMOTE_TO"}

func resourceGitopsAbacRule() *schema.Resource {
return &schema.Resource{
Expand All @@ -34,11 +34,14 @@ func resourceGitopsAbacRule() *schema.Resource {
Description: `
The type of resources the ABAC rules applies to. Possible values:
* gitopsApplications
* promotionFlows
* products
* environments
`,
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice([]string{
"gitopsApplications",
"gitopsApplications", "promotionFlows", "products", "environments",
}, false),
},
"teams": {
Expand Down Expand Up @@ -67,6 +70,9 @@ Action to be allowed. Possible values:
* TERMINATE_SYNC
* VIEW_POD_LOGS
* APP_ROLLBACK
* TRIGGER_PROMOTION
* RETRY_RELEASE
* PROMOTE_TO
`,
Type: schema.TypeSet,
Required: true,
Expand Down
55 changes: 53 additions & 2 deletions codefresh/resource_abac_rules_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ import (
"testing"

"github.com/codefresh-io/terraform-provider-codefresh/codefresh/cfclient"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"

"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
funk "github.com/thoas/go-funk"
)

Expand Down Expand Up @@ -41,6 +40,58 @@ func TestAccCodefreshAbacRulesConfig(t *testing.T) {
resource.TestCheckResourceAttr(resourceName, "tags.1", "production"),
),
},
{
Config: testAccCodefreshAbacRulesConfig(
"promotionFlows",
"",
"",
"",
[]string{"TRIGGER_PROMOTION"},
[]string{"staging"},
),
Check: resource.ComposeTestCheckFunc(
testAccCheckCodefreshAbacRulesExists(resourceName),
resource.TestCheckResourceAttr(resourceName, "entity_type", "promotionFlows"),
resource.TestCheckResourceAttr(resourceName, "actions.0", "TRIGGER_PROMOTION"),
resource.TestCheckResourceAttr(resourceName, "tags.0", "staging"),
),
},
{
Config: testAccCodefreshAbacRulesConfig(
"products",
"",
"",
"",
[]string{"TRIGGER_PROMOTION", "RETRY_RELEASE"},
[]string{"dev", "qa"},
),
Check: resource.ComposeTestCheckFunc(
testAccCheckCodefreshAbacRulesExists(resourceName),
resource.TestCheckResourceAttr(resourceName, "entity_type", "products"),
resource.TestCheckResourceAttr(resourceName, "actions.#", "2"),
resource.TestCheckTypeSetElemAttr(resourceName, "actions.*", "TRIGGER_PROMOTION"),
resource.TestCheckTypeSetElemAttr(resourceName, "actions.*", "RETRY_RELEASE"),
resource.TestCheckResourceAttr(resourceName, "tags.#", "2"),
resource.TestCheckTypeSetElemAttr(resourceName, "tags.*", "dev"),
resource.TestCheckTypeSetElemAttr(resourceName, "tags.*", "qa"),
),
},
{
Config: testAccCodefreshAbacRulesConfig(
"environments",
"",
"",
"",
[]string{"PROMOTE_TO"},
[]string{"production"},
),
Check: resource.ComposeTestCheckFunc(
testAccCheckCodefreshAbacRulesExists(resourceName),
resource.TestCheckResourceAttr(resourceName, "entity_type", "environments"),
resource.TestCheckResourceAttr(resourceName, "actions.0", "PROMOTE_TO"),
resource.TestCheckResourceAttr(resourceName, "tags.0", "production"),
),
},
{
ResourceName: resourceName,
ImportState: true,
Expand Down
6 changes: 6 additions & 0 deletions docs/resources/abac_rules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,14 @@ resource "codefresh_abac_rules" "app_rule" {
* TERMINATE_SYNC
* VIEW_POD_LOGS
* APP_ROLLBACK
* TRIGGER_PROMOTION
* RETRY_RELEASE
* PROMOTE_TO
- `entity_type` (String) The type of resources the ABAC rules applies to. Possible values:
* gitopsApplications
* promotionFlows
* products
* environments
- `teams` (Set of String) The IDs of the teams the ABAC rules apply to.

### Optional
Expand Down
Loading