refactor: compile against the forked OpenSearch package in fesen-httpclient - #22
Open
marevol wants to merge 1 commit into
Open
refactor: compile against the forked OpenSearch package in fesen-httpclient#22marevol wants to merge 1 commit into
marevol wants to merge 1 commit into
Conversation
…client The OpenSearch DTOs and query builders Fess uses are now forked into org.codelibs.fesen.opensearch inside fesen-httpclient, and Fess core has already migrated. LanguageHelper.createScript returns the forked Script, so the favorite count update has to follow. Rewrite the Script import onto the forked package, and drop the now-redundant provided-scope org.opensearch:opensearch declaration: the class arrives through Fess, which depends on fesen-httpclient. Nothing here used the jar's transitive dependencies.
marevol
force-pushed
the
fork/opensearch-migrate
branch
from
September 13, 2026 14:13
f6ac666 to
2e9cb13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fess is dropping the 17 MiB
org.opensearch:opensearchjar: the DTOs and query builders it uses are now forked intoorg.codelibs.fesen.opensearch.*insidefesen-httpclient, pruned from 8,578 classes to 2,645. This plugin follows.One import line.
api/classic/JsonApiManager.javatakes anorg.opensearch.script.ScriptfromLanguageHelper.createScript(...)and passes it tosetScript(...)— the type is dictated by that core signature, which moves in codelibs/fess#3439, so this plugin has no choice about when it migrates. Theprovideddeclaration oforg.opensearch:opensearchis removed; the class arrives through Fess.Verification
mvn clean package— 80 tests, 0 failures.Ordering
FavoriteResultfix from fix(favorite): follow the three-valued addUrl contract #19. If that lands first, rebasing drops the duplicate.