Skip to content

feat: add Hetzner Cloud server template and configuration files #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add Hetzner Cloud server template and configuration files #254

wants to merge 1 commit into from
+275 −0

Conversation

brymut
Copy link

@brymut brymut commented Jul 25, 2025 •
edited
Loading

Closes #209
/claim #209

Description

Added template for Hetzner cloud. Video of template setting up a workspace and connecting using VScode

hetzner.mp4

Type of Change

  • Feature/enhancement

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

Related Issues

#209

@brymut brymut force-pushed the brymut/add-hetzner-template branch from a70dd7c to ca222c3 Compare July 25, 2025 18:48
@algora-pbc algora-pbc bot mentioned this pull request Jul 25, 2025
Open
@brymut brymut force-pushed the brymut/add-hetzner-template branch 2 times, most recently from dacec3a to 6866f01 Compare July 25, 2025 19:34
@brymut brymut marked this pull request as ready for review July 25, 2025 19:34
@matifali matifali requested a review from DevelopmentCats July 29, 2025 03:01
@brymut brymut force-pushed the brymut/add-hetzner-template branch from ba8b12c to 536aca0 Compare July 29, 2025 15:07
@brymut
Copy link
Author

brymut commented Jul 30, 2025

Hi @DevelopmentCats, could you please have a quick look when you have a chance?

@matifali
Copy link
Member

@brymut, can you fix the failing CI? You may need to add an exception to the typos config.

https://github.com/coder/registry/actions/runs/16600024993/job/46963017795?pr=254#step:7:41

@brymut
Copy link
Author

brymut commented Jul 30, 2025

@matifali Failing CI is because of a variable being mistaken for a spelling mistake. Please check again

@matifali
Copy link
Member

@brymut you need to add an exception to this in .github/typos.toml

@brymut brymut force-pushed the brymut/add-hetzner-template branch from 536aca0 to 5ff1c7d Compare July 30, 2025 15:09
@brymut
Copy link
Author

brymut commented Jul 30, 2025 •
edited
Loading

@brymut you need to add an exception to this in .github/typos.toml

Sorry, I missed that exception handling, I've added the word to the list. Please re-run CI and have a look @matifali

DevelopmentCats
DevelopmentCats approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@DevelopmentCats DevelopmentCats left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I re-ran the CI but its still detecting it as a typo though. You might have to try setting the typo as just hel

@brymut brymut force-pushed the brymut/add-hetzner-template branch from ba2771b to 19e11a4 Compare July 31, 2025 07:17
@brymut
Copy link
Author

brymut commented Jul 31, 2025 •
edited
Loading

I re-ran the CI but its still detecting it as a typo though. You might have to try setting the typo as just hel

Thanks for the feedback, I've tested locally and changing the typo exception to "hel" works. @matifali / @DevelopmentCats could you please re-run the CI

matifali
matifali reviewed Jul 31, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions but looks good to me. I will approve after another review.

registry/brymut/templates/hetzner-linux/main.tf Outdated
display_name = "Home Usage"
interval = 600 # every 10 minutes
timeout = 30 # df can take a while on large filesystems
script = "coder stat disk --path /home/${lower(data.coder_workspace_owner.me.name)}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
script = "coder stat disk --path /home/${lower(data.coder_workspace_owner.me.name)}"
script = "coder stat disk --path /home/${local.username}"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will resolve this once you resolve my review last review comment below and we can merge this. @brymut

@brymut brymut force-pushed the brymut/add-hetzner-template branch from 19e11a4 to 96c431c Compare July 31, 2025 07:54
@brymut
Copy link
Author

brymut commented Jul 31, 2025

Left a few suggestions but looks good to me. I will approve after another review.

Applied requested changes @matifali

@brymut
Copy link
Author

brymut commented Jul 31, 2025

Hi @bpmct could you please have a look at this?

DevelopmentCats
DevelopmentCats requested changes Aug 1, 2025
View reviewed changes
registry/brymut/templates/hetzner-linux/main.tf Outdated
display_name = "Home Usage"
interval = 600 # every 10 minutes
timeout = 30 # df can take a while on large filesystems
script = "coder stat disk --path /home/${lower(local.username)}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove lower from this since you already do it in the locals as matifali suggested earlier

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh right, done 👍

@brymut brymut force-pushed the brymut/add-hetzner-template branch from ebd9791 to 8c92754 Compare August 1, 2025 07:53
@brymut brymut requested a review from DevelopmentCats August 1, 2025 07:54
@brymut
Copy link
Author

brymut commented Aug 1, 2025

Maybe @hugodutka could have a quick look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matifali matifali matifali left review comments

@DevelopmentCats DevelopmentCats Awaiting requested review from DevelopmentCats

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hetzner Cloud server template example
3 participants
@brymut @matifali @DevelopmentCats