-
Notifications
You must be signed in to change notification settings - Fork 76
feat: add cmux module #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions but nothing major, looks good otherwise 👍. Would be nice to see a few main.test.ts tests as well to verify the scripts work correctly.
|
|
||
| - **Parallel Agent Execution**: Run multiple AI agents simultaneously on different tasks | ||
| - **Workspace Isolation**: Each agent works in its own isolated environment | ||
| - **Git Divergence Visualization**: Track changes across different agent workspaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling out workspaces here seems potentially confusing for a module that is being installed inside a single workspace. Arguably it can be used from within the workspace to connect to other remote workspaces too but that seems like a power-user feature. I propose adjusting the wording here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a naming difference between cmux and Coder. For cmux a "workspace" is a single instace of a git worktree on a project (repo) you're working on. It's verbatim from: https://github.com/coder/cmux/?tab=readme-ov-file#features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's fine then. I still think it's worth calling out the difference in say, a parenthesis, (this refers to cmux workspaces, not Coder workspaces). Mainly because as a Coder module this may confuse others as it has me 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. That's valid. Thanks.
| default = null | ||
| } | ||
|
|
||
| variable "offline" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: This could also just be install, default true. I know it's probably used in other modules, but I think offline is not as descriptive and could be confusing.
| lifecycle { | ||
| precondition { | ||
| condition = !var.offline || !var.use_cached | ||
| error_message = "Offline and Use Cached can not be used together" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| error_message = "Offline and Use Cached can not be used together" | |
| error_message = "The \"offline\" and \"use_cached\" parameters can not be used together." |
Description
Type of Change
Module Information
Path:
registry/[namespace]/modules/[module-name]New version:
v1.0.0Breaking change: [ ] Yes [ ] No
Template Information
Path:
registry/[namespace]/templates/[template-name]Testing & Validation
bun test)bun fmt)Related Issues