Skip to content

Conversation

@ibetitsmike
Copy link

@ibetitsmike ibetitsmike commented Oct 31, 2025

Description

Type of Change

  • New module
  • New template
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/[namespace]/modules/[module-name]
New version: v1.0.0
Breaking change: [ ] Yes [ ] No

Template Information

Path: registry/[namespace]/templates/[template-name]

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun fmt)
  • Changes tested locally

Related Issues

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions but nothing major, looks good otherwise 👍. Would be nice to see a few main.test.ts tests as well to verify the scripts work correctly.


- **Parallel Agent Execution**: Run multiple AI agents simultaneously on different tasks
- **Workspace Isolation**: Each agent works in its own isolated environment
- **Git Divergence Visualization**: Track changes across different agent workspaces
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling out workspaces here seems potentially confusing for a module that is being installed inside a single workspace. Arguably it can be used from within the workspace to connect to other remote workspaces too but that seems like a power-user feature. I propose adjusting the wording here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a naming difference between cmux and Coder. For cmux a "workspace" is a single instace of a git worktree on a project (repo) you're working on. It's verbatim from: https://github.com/coder/cmux/?tab=readme-ov-file#features

Copy link
Member

@mafredri mafredri Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's fine then. I still think it's worth calling out the difference in say, a parenthesis, (this refers to cmux workspaces, not Coder workspaces). Mainly because as a Coder module this may confuse others as it has me 😄.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. That's valid. Thanks.

default = null
}

variable "offline" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: This could also just be install, default true. I know it's probably used in other modules, but I think offline is not as descriptive and could be confusing.

lifecycle {
precondition {
condition = !var.offline || !var.use_cached
error_message = "Offline and Use Cached can not be used together"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
error_message = "Offline and Use Cached can not be used together"
error_message = "The \"offline\" and \"use_cached\" parameters can not be used together."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants