Skip to content

Checkmake files #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Checkmake files #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
build:
@echo Building...

install:
echo Installing...
Comment on lines +1 to +5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Declare a default all target and mark all entry points as .PHONY.

Most build tools (incl. checkmake) expect a conventional all target to act as the default entry-point and to be listed in the .PHONY declaration together with every recipe that does not create a file of the same name.
Recommend:

+.PHONY: all build install clean test
+
+all: build
+
 build:
 	@echo Building...
 
 install:
-	echo Installing...
+	@echo Installing...

Adds:
• default all alias → CI/CD friendly
• .PHONY list covers every virtual target
• quiets static-analysis “minphony” warnings
• consistent silent-echo for install

🤖 Prompt for AI Agents 
In the Makefile at lines 1 to 5, add a default target named "all" that depends
on the "build" target to serve as the conventional entry point. Also, declare
all targets including "all", "build", and "install" as .PHONY to indicate they
are not files. Additionally, modify the "install" target to use silent echo
(prefix with @) for consistency and to reduce noise during execution.


.PHONY: clean
clean:
-rm -rf dist/