Skip to content

feat: idling after 24h for Claw namespaces - #1315

Merged
alexeykazakov merged 1 commit into
codeready-toolchain:masterfrom
xcoulon:claw-tier-24h-idler
Aug 10, 2026
Merged

feat: idling after 24h for Claw namespaces#1315
alexeykazakov merged 1 commit into
codeready-toolchain:masterfrom
xcoulon:claw-tier-24h-idler

Conversation

@xcoulon

@xcoulon xcoulon commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

kinda revert of #1280, but allow running for 24h instead of default 12h

e2e tests for codeready-toolchain/host-operator#1292

Signed-off-by: Xavier Coulon xcoulon@redhat.com

Summary by CodeRabbit

  • Bug Fixes
    • Updated the Claw tier’s idle timeout expectation to 24 hours.

kinda revert of codeready-toolchain#1280, but allow running for 24h instead of default 12h

e2e tests for codeready-toolchain/host-operator#1292

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: a6caaf24-5bc6-44de-9ee2-4328aaddba75

📥 Commits

Reviewing files that changed from the base of the PR and between 7a2d4e7 and 61caaee.

📒 Files selected for processing (1)
  • testsupport/tiers/checks.go
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • codeready-toolchain/api (manual)
  • codeready-toolchain/toolchain-common (manual)
  • codeready-toolchain/host-operator (manual) → reviewed against open PR #1292 claw-tier-24h-idler instead of the default branch
  • codeready-toolchain/toolchain-e2e (manual)
📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Build & push operator bundles & dashboard image for e2e tests
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • testsupport/tiers/checks.go
🔇 Additional comments (1)
testsupport/tiers/checks.go (1)

593-593: LGTM!


Walkthrough

The Claw tier check now expects a 24-hour idler timeout instead of zero seconds. The namespace target remains claw.

Changes

Claw idler timeout

Layer / File(s) Summary
Update Claw timeout check
testsupport/tiers/checks.go
The expected Claw idler timeout changes from 0 to 24*3600 seconds. The namespace remains claw.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: test

Suggested reviewers: alexeykazakov, matousjobanek

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the change to make Claw namespaces idle after 24 hours.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot added the test Work that adds, fixes, or maintains automated tests or coverage (unit, integration, e2e, flakiness) label Aug 10, 2026
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexeykazakov
alexeykazakov merged commit 483f412 into codeready-toolchain:master Aug 10, 2026
9 of 10 checks passed
@xcoulon
xcoulon deleted the claw-tier-24h-idler branch August 11, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved test Work that adds, fixes, or maintains automated tests or coverage (unit, integration, e2e, flakiness)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants