Skip to content

Conversation

LunarWatcher
Copy link
Contributor

#1558 introduced a max-width condition that, for reasons I don't understand and likely never will, caused comment boxes to start underflowing:

Screenshot showing a comment with the meta header not taking up the full available width

Fix verified in:

  • /thread/{id}
    • Selected thread + when embedded on that page
  • /posts/{id}

This PR fixes this bug. AFAIK, it has not been reported anywhere (yet).

@cellio cellio requested a review from a team April 9, 2025 23:39
@LunarWatcher
Copy link
Contributor Author

LunarWatcher commented Apr 10, 2025

Is the test failure one of the flaky tests addressed in #1569? I don't see how this tiny CSS change would cause that to fail on one single ruby version otherwise

@Oaphi
Copy link
Member

Oaphi commented Apr 10, 2025

Is the test failure one of the flaky tests addressed in #1569? I don't see how this tiny CSS change would cause that to fail on one single ruby version otherwise

Yeah, judging by the error message, it's the flaky system tests, yeah, I'll rerun the pipeline shortly

@Oaphi
Copy link
Member

Oaphi commented Apr 10, 2025

Oh, I just realized I've noticed the issue too and fixed it in my PR with fixes related to the button: 2e7578c. Not sure how to proceed, though, our fixes might be complementary

@LunarWatcher
Copy link
Contributor Author

Maybe it's worth reconsidering the problematic rule instead of doing this fix? I don't think the entire subtree needs a max-width, so maybe

-   * {
+   > * {
      max-width: 100%;
    }

Or something like that? I have not tested this rule, nor have I checked if that backfires, but I'm pretty sure the problem it was trying to fix was immediate descendants of the post, and not the entire subtree. Might've been an either inline mathjax or mathjax block fix as well, but that could be done separately

@ArtOfCode-
Copy link
Member

Superseded by #1584

@ArtOfCode- ArtOfCode- closed this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants