Skip to content

Conversation

@JonaLoeffler
Copy link

This should solve #55, I tested it locally and it seems to be working fine.

Please don't spare me with feedback, I am not sure if this is the best way to do this 🙂

@codymikol
Copy link
Owner

Thank you for your contribution! Would you mind taking a quick look at the contributing guide? That should show you how to run the tests and format the project. It looks like some arguments were added that the current test cases aren't expecting. Think you could update the failing test cases that prove out the non-module functionality and possibly add a few more that prove out the new multi module paths?

@codymikol
Copy link
Owner

If you need any help, just let me know!

@JonaLoeffler
Copy link
Author

Unfortunately I didn't find the time to come back to this before my vacation, I'll fix the PR once I am back in 3 weeks 👍

@codymikol
Copy link
Owner

No worries, I hope you have a great vacation 😃

@JonaLoeffler
Copy link
Author

Hi there, I am back from vacation and managed to put in some improvements on the PR. Would you mind running the workflows again and checking it out?

@JonaLoeffler
Copy link
Author

I see that there is work happening towards a v2.0.0, thanks for putting in the effort 🙂

I suspect this change is no longer necessary after a v2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants