github-repo-stats #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github only displays stats for the past 14 days, so adding this action should let us collect traffic stats indefinitely going forward. Unfortunately, stats from more than two weeks ago are lost.
| - name: GHRS | ||
| uses: jgehrcke/github-repo-stats@HEAD | ||
| with: | ||
| ghpagesprefix: https://jgehrcke.github.io/ghrs-test |
There was a problem hiding this comment.
Ah. now I see the source of your questions on slack.
Yes. something doesn't smell good here by the way this looks.
It's conceivable the way this is set up that the token could be slurped up by the jgehrcke code.
Don't know enough to put my finger on how safe this really is.
Gut reaction is that a safer way might be to copy the contents of that jgekrcke stuff into a repo owned by us, if the licensing allows.
Again, don't really know enough to be sure at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github only displays stats for the past 14 days, so adding this action should let us collect traffic stats indefinitely going forward. Unfortunately, stats from more than two weeks ago are lost.