Skip to content

Plone 6.2 only support - #105

Merged
erral merged 21 commits into
masterfrom
config-with-plone-meta-2.4.0
Mar 9, 2026
Merged

Plone 6.2 only support#105
erral merged 21 commits into
masterfrom
config-with-plone-meta-2.4.0

Conversation

@erral

@erral erral commented Mar 7, 2026

Copy link
Copy Markdown
Member
  • Support Plone 6.2 only
  • Remove Plone 6.0 and 6.1 support
  • src-layout
  • native namespaces

Supercedes #94

@erral
erral requested a review from gforcada March 7, 2026 12:10
@erral

erral commented Mar 7, 2026

Copy link
Copy Markdown
Member Author

I reached this point, I don't know why the coverage phase fails :(

@gforcada

gforcada commented Mar 9, 2026

Copy link
Copy Markdown
Member

If you look at the Summary you can see the output:

...
Tear down plone.testing.zca.LayerCleanup in 0.002 seconds.
Total: 16 tests, 0 failures, 0 errors and 0 skipped in 6.660 seconds.
No data to report.
coverage: exit 1 (0.10 seconds) /home/runner/work/plone.formwidget.geolocation/plone.formwidget.geolocation> coverage report -m --format markdown pid=2625
coverage: FAIL code 1 (43.47 seconds)
evaluation failed :( (43.60 seconds)

As you moved to src layout, probably there is some coverage setting that does not expect the code to be there, but rather at plone and under? 🤔

@gforcada gforcada left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 💯

did you use https://6.docs.plone.org/developer-guide/standardize-python-project-configuration.html and https://6.docs.plone.org/developer-guide/native-namespace.html guides? Any feedback there to improve the experience would be great! 🙇🏾

As 6.2 is getting closer to get ready, it will be great to have those two guides in very good shape to make the porting effort of all 100+ collective (and internal!) add-ons to be 6.2 compatible as smooth as possible.

@erral

erral commented Mar 9, 2026

Copy link
Copy Markdown
Member Author

Ah, coverage configuration! Let's try ...

@erral

erral commented Mar 9, 2026

Copy link
Copy Markdown
Member Author

Nice job! 💯

did you use https://6.docs.plone.org/developer-guide/standardize-python-project-configuration.html and https://6.docs.plone.org/developer-guide/native-namespace.html guides? Any feedback there to improve the experience would be great! 🙇🏾

Nope, I didn't follow the guides, but the PRs that you and Maurits did for the rest of plone packages...

@erral
erral merged commit b3a8d51 into master Mar 9, 2026
6 checks passed
@erral
erral deleted the config-with-plone-meta-2.4.0 branch March 9, 2026 18:03
@erral erral mentioned this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants