ArraySchema: prevent ArgumentOutOfRangeException at DeleteByIndex(). closes #238

endel · endel · commit 0839074d7a0b · 2025-04-02T23:09:23.000-03:00
diff --git a/Assets/Colyseus/Runtime/Colyseus/Serializer/Schema/Types/ArraySchema.cs b/Assets/Colyseus/Runtime/Colyseus/Serializer/Schema/Types/ArraySchema.cs
@@ -100,6 +100,13 @@ public object GetByIndex(int index)
 		public void DeleteByIndex(int index)
 		{
 			deletedKeys.Add(index);
+
+			// skip if index is out of range
+			if (index >= items.Count)
+			{
+				return;
+			}
+
 			items[index] = default(T);
 		}
 
diff --git a/Assets/Colyseus/package.json b/Assets/Colyseus/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "io.colyseus.sdk",
-	"version": "0.16.8",
+	"version": "0.16.9",
 	"displayName": "Colyseus SDK",
 	"description": "Colyseus Multiplayer SDK for Unity",
 	"unity": "2019.1",

Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,13 @@ public object GetByIndex(int index)`
`100`	`100`	`public void DeleteByIndex(int index)`
`101`	`101`	`{`
`102`	`102`	`deletedKeys.Add(index);`
	`103`	`+`
	`104`	`+ // skip if index is out of range`
	`105`	`+ if (index >= items.Count)`
	`106`	`+ {`
	`107`	`+ return;`
	`108`	`+ }`
	`109`	`+`
`103`	`110`	`items[index] = default(T);`
`104`	`111`	`}`
`105`	`112`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "io.colyseus.sdk",`
`3`		`- "version": "0.16.8",`
	`3`	`+ "version": "0.16.9",`
`4`	`4`	`"displayName": "Colyseus SDK",`
`5`	`5`	`"description": "Colyseus Multiplayer SDK for Unity",`
`6`	`6`	`"unity": "2019.1",`