Upgrade to Scala 3.7.0-RC1 #4745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Basically all tests pass now, so we can count this as done until 3.7.0 final is out |
lihaoyi
added a commit
that referenced
this pull request
Mar 30, 2025
lefou
pushed a commit
to lefou/mill
that referenced
this pull request
Mar 30, 2025
Small adjustments to bring them into line with vanilla `.scala` file semantics, and other cleanups, backported from com-lihaoyi#4745
Merged
lihaoyi
added a commit
that referenced
this pull request
May 6, 2025
|
Superseded by #5075 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4609 and #4733
Apart from just bumping the Scala version, this PR overhauls the Mill codegen to take advantage of scala/improvement-proposals#100. This lets us remove a whole bunch of hacks we were previously using to avoid needing the
.packageprefix: alias imports, exports, codegen renames, etc. which are now all unnecessary.All the codegen-related example tests in
./mill 'example.large.multi[_].local.server'pass, so it seems to work. Only hitting some issues with the-experimentalflag stopping us from rolling this out more broadlyUpstream issues
CheckUnusedon Mill repo after updating to Scala 3.7.0-RC1 when-Wunused:allis enabled scala/scala3#22829"-language:experimental.packageObjectValues"compiler flag seems to be missing scala/scala3#22830error overriding method may not override non-experimental memberscala/scala3#22831This PR is just for early testing, once 3.7.0-final is out we can update the PR target that before merging it