Skip to content

fix: support adding comments for fork repo #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

fix: support adding comments for fork repo #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0bf5f59
feat: pdate commit-check.yml
shenxianpeng Oct 29, 2024
e045b34
fxi: update commit-check.yml
shenxianpeng Oct 29, 2024
4241f13
Merge branch 'main' into shenxianpeng-patch-1
shenxianpeng Oct 29, 2024
04b278c
test: Update commit-check.yml
shenxianpeng Oct 29, 2024
894c2c5
test: Update commit-check.yml
shenxianpeng Oct 29, 2024
986dcb9
test: Update main.py
shenxianpeng Oct 29, 2024
fb80c7a
test: Update main.py
shenxianpeng Oct 29, 2024
130dcfe
test: Update main.py
shenxianpeng Oct 29, 2024
f163f3a
test: Update requirements.txt
shenxianpeng Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/commit-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ jobs:
commit-check:
runs-on: ubuntu-latest
permissions: # use permissions because of use pr-comments
contents: read
contents: write
pull-requests: write
id-token: write
steps:
- uses: actions/checkout@v4
with:
Expand Down
5 changes: 3 additions & 2 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import sys
import subprocess
import re
from github import Github
from github import Github, GithubRetry


# Constants for message titles
Expand Down Expand Up @@ -104,7 +104,8 @@ def add_pr_comments() -> int:
pr_number = os.getenv("GITHUB_REF").split("/")[-2]

# Initialize GitHub client
g = Github(token)
# g = Github(token)
g = Github(token, retry=GithubRetry())
Comment on lines +107 to +108
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider enhancing error handling for specific GitHub API errors.

The current error handling catches all exceptions generically. Consider adding specific handling for GitHub API errors, especially for authentication and permission issues that are common with forked repositories.

         g = Github(token, retry=GithubRetry())
         repo = g.get_repo(repo_name)
         pull_request = repo.get_issue(int(pr_number))
@@ -144,8 +144,17 @@
         return 0 if result_text is None else 1
-    except Exception as e:
-        print(f"Error posting PR comment: {e}", file=sys.stderr)
-        return 1
+    except github.GithubException as e:
+        if e.status == 403:
+            print(f"Permission denied: {e.data.get('message', '')}", file=sys.stderr)
+            print("This might be due to restricted permissions on forked repositories.", file=sys.stderr)
+        elif e.status == 404:
+            print(f"Resource not found: {e.data.get('message', '')}", file=sys.stderr)
+        else:
+            print(f"GitHub API error: {e}", file=sys.stderr)
+        return 1
+    except Exception as e:
+        print(f"Unexpected error: {e}", file=sys.stderr)
+        return 1

Also applies to: 144-146

repo = g.get_repo(repo_name)
pull_request = repo.get_issue(int(pr_number))

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# For details please see: https://github.com/commit-check/commit-check
commit-check==0.8.5
# Interact with the GitHub API.
PyGithub==2.4.0
PyGithub==2.1.0.post0
Loading