Don't update the DOM if the toggle has been removed #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if the toggle causes the element to be removed from the DOM, the code that updates the DOM fails with `TypeError: Cannot read property 'querySelector' of null`
mweidner037
force-pushed
the
handle-null-elements
branch
from
e3f4704 to
b22dab3
Compare
|
Now (in version 9.0.3) Ember yells at us if a rerender during cleanup accesses a computed property (in our app, it's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the toggle causes the element to be removed from the DOM, the code that updates the DOM fails with
TypeError: Cannot read property 'querySelector' of null