Fix/bottom nav visibility mediadetails (#6520)

* Ensure bottom navigation bar is visible on back navigation

* Prevent hiding bottom navigation bar in MediaDetailPagerFragment

* Removed the  redundant showTabs() calls from onBackPressed() as they are no longer needed

* Explicitly hide and show the bottom navigation bar on entering/exiting Media Details

---------

Co-authored-by: Nicolas Raoul <[email protected]>

Author: Kota-Jagadeesh

app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt

@@ -87,6 +87,7 @@ import fr.free.nrw.commons.category.CategoryClient
 import fr.free.nrw.commons.category.CategoryDetailsActivity
 import fr.free.nrw.commons.category.CategoryEditHelper
 import fr.free.nrw.commons.contributions.ContributionsFragment
+import fr.free.nrw.commons.contributions.MainActivity
 import fr.free.nrw.commons.coordinates.CoordinateEditHelper
 import fr.free.nrw.commons.databinding.FragmentMediaDetailBinding
 import fr.free.nrw.commons.delete.DeleteHelper
@@ -793,6 +794,14 @@ class MediaDetailFragment : CommonsDaggerSupportFragment(), CategoryEditHelper.C
         super.onDestroyView()
     }
 
+    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
+        super.onViewCreated(view, savedInstanceState)
+        if (activity is MainActivity) {
+            //explicitly hides the tabs when the media details screen is opened.
+            (activity as MainActivity).hideTabs()
+        }
+    }
+
     private fun setTextFields(media: Media) {
         setupImageView()
         binding.mediaDetailTitle.text = media.displayTitle

app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt

@@ -109,8 +109,6 @@ class MediaDetailPagerFragment : CommonsDaggerSupportFragment(), OnPageChangeLis
         // If fragment is associated with ProfileActivity, then hide the tabLayout
         if (activity is ProfileActivity) {
             (activity as ProfileActivity).setTabLayoutVisibility(false)
-        } else if (activity is MainActivity) {
-            (activity as MainActivity).hideTabs()
         }
 
         binding!!.mediaDetailsPager.adapter = adapter
@@ -142,6 +140,14 @@ class MediaDetailPagerFragment : CommonsDaggerSupportFragment(), OnPageChangeLis
         initProvider()
     }
 
+    override fun onDestroyView() {
+        super.onDestroyView()
+        if (activity is MainActivity) {
+            (activity as MainActivity).showTabs()
+        }
+        binding = null
+    }
+
     /**
      * initialise the provider, based on from where the fragment was started, as in from an activity
      * or a fragment