Reduce return type of function #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done based on user defined reduction rule and using another wrapper function Required by test01_reduce_binary
|
Perhaps that’s something @wlav can review. |
|
This one, too, I don't understand why this has to be part of a back-and-forth across the public interface as opposed to just sending the types to be reduced and resolving everything in the backend. Every public API added is extra maintenance and locks you in. |
|
I am merging this, even though emscripten did not run for some reason |
Vipul-Cariappa
merged commit eac1225
into
compiler-research:master
48 of 53 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done based on user defined reduction rule and using another wrapper function
Required by test01_reduce_binary
Depends on compiler-research/cppyy-backend#164