-
Notifications
You must be signed in to change notification settings - Fork 30
fix GetVariableOffset for templated static variable #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix GetVariableOffset for templated static variable #629
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
510222c
to
aa78f32
Compare
clang-tidy review says "All clean, LGTM! 👍" |
aa78f32
to
517b64d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
lib/CppInterOp/CppInterOp.cpp
Outdated
@@ -1492,7 +1492,8 @@ intptr_t GetVariableOffset(compat::Interpreter& I, Decl* D, | |||
#ifdef CPPINTEROP_USE_CLING | |||
cling::Interpreter::PushTransactionRAII RAII(&getInterp()); | |||
#endif // CPPINTEROP_USE_CLING | |||
getSema().InstantiateVariableDefinition(SourceLocation(), VD); | |||
getSema().InstantiateVariableDefinition(SourceLocation(), VD, true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: no header providing "llvm::sys::DynamicLibrary" is directly included [misc-include-cleaner]
lib/CppInterOp/CppInterOp.cpp:40:
- #if CLANG_VERSION_MAJOR >= 19
+ #include <llvm/Support/DynamicLibrary.h>
+ #if CLANG_VERSION_MAJOR >= 19
517b64d
to
8c515ca
Compare
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
+ Coverage 79.64% 79.67% +0.03%
==========================================
Files 9 9
Lines 3930 3931 +1
==========================================
+ Hits 3130 3132 +2
+ Misses 800 799 -1
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
This is a bug report.
Will help fix a test in cppyy.