fix JitCall codegen for function with lambda as return value #678
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
==========================================
+ Coverage 79.61% 79.71% +0.09%
==========================================
Files 9 9
Lines 3925 3944 +19
==========================================
+ Hits 3125 3144 +19
Misses 800 800
🚀 New features to boost your workflow:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
lib/CppInterOp/CppInterOp.cpp
Outdated
| DeclarationName DFunction = &getASTContext().Idents.get("function"); | ||
| auto result = getSema().getStdNamespace()->lookup(DFunction); | ||
| if (result.empty()) | ||
| Cpp::Declare("#include <functional>"); |
There was a problem hiding this comment.
I feel uncomfortable including and now . I am not sure how else to solve this but is there some way to write our own minimal std::function-like class that does what we need it to?
| bool IsLambdaClass(TCppType_t type) { | ||
| QualType QT = QualType::getFromOpaquePtr(type); | ||
| if (auto* CXXRD = QT->getAsCXXRecordDecl()) { | ||
| return CXXRD->isLambda(); |
There was a problem hiding this comment.
FYI isLambdaCallOperator in clang.
There was a problem hiding this comment.
isLambdaCallOperator takes a CXXMethodDecl, but we are using QualType to check here.
Also, we are not checking if the function is the lambda call operator; instead, we are checking if the given class is a lambda class.
Vipul-Cariappa
force-pushed
the
dev/lambda
branch
from
3cc7e4f to
aada7a9
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
lib/CppInterOp/CppInterOp.cpp
Outdated
| } | ||
| if (auto* CXXRD = QT->getAsCXXRecordDecl()) { | ||
| if (CXXRD->isLambda()) { | ||
| static bool flag = false; |
There was a problem hiding this comment.
No statics anymore. We have a stack of interpreters. Maybe we feed that as part of Cpp::CreateIntepreter...
Vipul-Cariappa
force-pushed
the
dev/lambda
branch
from
aada7a9 to
1a8c719
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Description
Fixes # (issue)
Helps fix a test in cppyy
Type of change
Please tick all options which are relevant.
Testing
Checklist