Fix XEUS_CPP_RESOURCE_DIR in Emscripten build instructions #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
=======================================
Coverage 79.57% 79.57%
=======================================
Files 9 9
Lines 3921 3921
=======================================
Hits 3120 3120
Misses 801 801 🚀 New features to boost your workflow:
|
mcbarton
force-pushed
the
fix-wasm-simd-documentation-xeus-cpp
branch
from
8bb40d8 to
e9d1192
Compare
|
@anutosh491 can you review this for me? Should be simple to review. Unlike the ci, in the documentation we never define LLVM_VERSION, so xeus-cpp never gets the correct resource directory it needs to do the simd example. This PR just makes this simple change. |
anutosh491
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
Fixes # (issue)
Type of change
This PR makes it so the SIMD Acceleration through WebAssembly Intrinsics example works if you follow the Emscripten build instructions
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist