Skip to content

Backport enable exception handling patch to llvm 19 #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Aug 1, 2025

Description

Please include a summary of changes, motivation and context for this PR.

This PR backports the enable exception handling patch to llvm 19, and according to my local testing will allow the failing test in #678 to pass, so that the emscripten workflow will go green. For this to work, you would need to clear the cache on main of Emscripten llvm 19 builds, merge this in, and once the workflow on main has rebuilt the cache, rebase that PR.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton force-pushed the backport-enable_exception_handling.patch-to-llvm-19 branch from b0e4802 to 4f5200b Compare August 1, 2025 10:21
@mcbarton
Copy link
Collaborator Author

mcbarton commented Aug 1, 2025

@Vipul-Cariappa Here is the backported patch you need for your PR.

Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.64%. Comparing base (b7ab5ae) to head (4f5200b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   79.64%   79.64%           
=======================================
  Files           9        9           
  Lines        3930     3930           
=======================================
  Hits         3130     3130           
  Misses        800      800           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Vipul-Cariappa Vipul-Cariappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.
Looks good to me if the tests pass.

@mcbarton mcbarton merged commit 55b47ba into compiler-research:main Aug 1, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants