Skip to content

Issue 1031 joinLeftMerge #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: issue_1031_joinInnerMerge
Choose a base branch
from
Draft

Issue 1031 joinLeftMerge #1418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/Streamly/Internal/Data/Stream/IsStream/Top.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ module Streamly.Internal.Data.Stream.IsStream.Top
, joinInnerMerge
, hashInnerJoin
, leftJoin
, mergeLeftJoin
, joinLeftMerge
, hashLeftJoin
, outerJoin
, mergeOuterJoin
Expand Down Expand Up @@ -383,11 +383,14 @@ hashLeftJoin = undefined
--
-- Time: O(m + n)
--
-- /Unimplemented/
{-# INLINE mergeLeftJoin #-}
mergeLeftJoin :: -- Monad m =>
-- /Pre-release/
{-# INLINE joinLeftMerge #-}
joinLeftMerge :: (IsStream t, MonadIO m, Eq a, Eq b) =>
(a -> b -> Ordering) -> t m a -> t m b -> t m (a, Maybe b)
mergeLeftJoin _eq _s1 _s2 = undefined
joinLeftMerge eq s1 =
IsStream.fromStreamD
. StreamD.joinLeftMerge eq (IsStream.toStreamD s1)
. IsStream.toStreamD

-- XXX We can do this concurrently.
--
Expand Down
Loading