Add a Builder data type for incremental appends #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the renaming in Prelude.
pranaysashank
approved these changes
Sep 24, 2020
| -- > extendL xs b = build xs <> b | ||
| -- | ||
| -- /Internal/ | ||
| -- |
Member
There was a problem hiding this comment.
Annotating with time complexity is useful.
Member
Author
There was a problem hiding this comment.
The problem is that the complexity is not associated with this operation as such but with the later consumption of the container. Its explained in the overall docs.
Add benchmark for Monoid builder
Member
|
What is the idea behind builder? I believe it is related to the work you are doing on |
This was referenced Sep 24, 2020
So that we do not depend on the semigroup instance. Ideally, we do not want a semigroup instance in streams as it is frought with performance problems when left associated. Instead, we should use the builder to compose streams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.