Skip to content

Conversation

wizardsd
Copy link

Made it possible to use clang-cl.exe as a compiler on Windows in Visual Studio 2022.

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @wizardsd

PRs with changes for Conan 1.X should go to develop branch, not master.

I think the elseif(NOT MSVC_VERSION VERSION_LESS 1930 AND MSVC_VERSION VERSION_LESS 1950) was already merge to develop

Also, please take not that the Conan 1.X integration is no longer recommended. If there are risks of breaking, changes might not be merged. It doesn't seem high risk in this specific case, but we need to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants