-
Notifications
You must be signed in to change notification settings - Fork 260
Add support for CONAN_INSTALL_BUILD_CONFIGURATIONS #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop2
Are you sure you want to change the base?
Add support for CONAN_INSTALL_BUILD_CONFIGURATIONS #707
Conversation
@jcar87 I've updated the docs, but don't know what you want to do for the tests. If you're happy to take care of that, please go ahead and push commits to my branch as needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, many thanks for your contribution @craigscott-crascit
I'd like to have the feedback from @jcar87 too.
fa55dd6
to
352518b
Compare
I fixed the failing test. Would be good to trigger another round of CI jobs to confirm that was the only problem. |
352518b
to
03017e2
Compare
I also added a couple of tests for the new |
Thanks @craigscott-crascit for the PR and for taking the time to implement the tests - our test suite in Need to rebase this on top of |
Yes, please take it over and push changes as you wish. Thanks. |
Let the user or project override the set of build types we execute the conan install command for. This is most useful for enabling projects to build only one configuration when using a multi-config generator, but it can also be used to install for multiple build types with a single-config generator.
03017e2
to
dcd7407
Compare
The tests are failing for a very interesting set of circumstances. (The main being that in that Test class, the build directory is reused and doing an actual build highlights an actual issue with the Conan Need to discuss with @memsharded tomorrow, when we have a single config CMake generator, runing For a multi config generator, I'm not sure 100% it would be an issue, but double checking. for what it's worth, all of these problems should go away with the |
`conan install` will then be invoked once for each build type. | ||
This can be used with both single- and multi-configuration generators. | ||
For example: | ||
* `-DCONAN_INSTALL_BUILD_CONFIGURATIONS=Release;Debug`: execute `conan install` for both `Release` and `Debug` build types, even for single-configuration generators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're saying only a single value can be given in CONAN_INSTALL_BUILD_CONFIGURATIONS
when using a single-config generator, then this needs to be reworded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, working on this!
I cannot express how happy the end of that comment makes me. :) |
Co-authored-by: Craig Scott <[email protected]>
Let the user or project override the set of build types we execute the conan install command for. This is most useful for enabling projects to build only one configuration when using a multi-config generator, but it can also be used to install for multiple build types with a single-config generator.
Fixes: #705