Skip to content

Upgrade cel-python to 0.4.0 and update usage #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2025
Merged

Upgrade cel-python to 0.4.0 and update usage #2015

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f78772
celpy fix
fangnx Aug 1, 2025
d68fee3
fix
fangnx Aug 1, 2025
350b0c7
update
fangnx Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/confluent_kafka/schema_registry/rules/cel/cel_field_presence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ def macro_has_eval(self, exprlist):
_has_state.in_has = False
return result

e = Evaluator(ast=self.ast, activation=self.new_activation(context), functions=self.functions)
value = e.evaluate()
e = Evaluator(ast=self.ast, activation=self.new_activation(), functions=self.functions)
Copy link
Preview

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new_activation() method is being called without the context parameter that was previously passed. Verify that this method can handle being called without parameters and that the context will be properly available when passed to evaluate().

Suggested change
e = Evaluator(ast=self.ast, activation=self.new_activation(), functions=self.functions)
e = Evaluator(ast=self.ast, activation=self.new_activation(context), functions=self.functions)

Copilot uses AI. Check for mistakes.

value = e.evaluate(context)
return value