Skip to content

Conversation

austinvazquez
Copy link
Member

Release notes: https://github.com/opencontainers/runc/releases/tag/v1.2.6

This is the sixth patch release in the 1.2.z series of runc.
It primarily fixes an issue with runc exec vs time namespace,
and a compatibility issue with older kernels.
Fixed
Fix a stall issue that would happen if setting O_CLOEXEC with
CloseExecFrom failed (opencontainers/runc#4647).
runc now properly handles joining time namespaces (such as with
runc exec). Previously we would attempt to set the time offsets
when joining, which would fail. (opencontainers/runc#4635, opencontainers/runc#4649)
Handle EINTR retries correctly for socket-related direct
golang.org/x/sys/unix system calls. (opencontainers/runc#4650)
We no longer use F_SEAL_FUTURE_WRITE when sealing the runc binary, as it
turns out this had some unfortunate bugs in older kernel versions and was
never necessary in the first place. (opencontainers/runc#4651, opencontainers/runc#4640)
Removed
Remove Fexecve helper from libcontainer/system. Runc 1.2.1 removed
runc-dmz, but we forgot to remove this helper added only for that. (opencontainers/runc#4646)
Changed
Use Go 1.23 for official builds, run CI with Go 1.24 and drop Ubuntu 20.04
from CI. We need to drop Ubuntu 20.04 from CI because Github Actions
announced it's already deprecated and it will be discontinued soon. (opencontainers/runc#4648)

Diff: opencontainers/runc@v1.2.5...v1.2.6

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@austinvazquez
Copy link
Member Author

/test all

Signed-off-by: Austin Vazquez <[email protected]>
@austinvazquez austinvazquez force-pushed the update-runc-binary-1.2.6 branch from 9670ce0 to 3e96f1a Compare March 19, 2025 17:07
@austinvazquez austinvazquez marked this pull request as ready for review March 19, 2025 18:33
@austinvazquez austinvazquez added cherry-pick/1.6.x Change to be cherry picked to release/1.6 branch cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch labels Mar 19, 2025
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Mar 21, 2025
@AkihiroSuda AkihiroSuda added this pull request to the merge queue Mar 21, 2025
Merged via the queue into containerd:main with commit 4e615ba Mar 21, 2025
58 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Mar 21, 2025
@djdongjin
Copy link
Member

/cherrypick release/2.0 release/1.7 release/1.6

@k8s-infra-cherrypick-robot

@djdongjin: new pull request created: #11583

In response to this:

/cherrypick release/2.0 release/1.7 release/1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@djdongjin
Copy link
Member

/cherrypick release/1.7

@djdongjin
Copy link
Member

/cherrypick release/1.6

@k8s-infra-cherrypick-robot

@djdongjin: new pull request created: #11584

In response to this:

/cherrypick release/1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@djdongjin: new pull request created: #11585

In response to this:

/cherrypick release/1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@austinvazquez austinvazquez added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch and removed cherry-pick/1.6.x Change to be cherry picked to release/1.6 branch cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch labels May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch size/XS

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants