-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Remove additional fuzzers from instrumentation repo #12059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove additional fuzzers from instrumentation repo #12059
Conversation
cc: @AdamKorcz |
f5fff79
to
ab65c4a
Compare
@austinvazquez I am not sure that this will fix the CI issue. Now you are just cloning in the build script instead of the Dockerfile, but that is not the problem. The problem comes when building and running the instrumentation library. |
Okay it hit me, we cannot simply have each branch specify the dependency version because currently upstream oss-fuzz is floating on containerd main. So the |
This change removes the additional AdamKorcz/instrumentation fuzzers from CI until the oss-fuzz can implement a mechanism to specify the project branch as an argument through its GitHub Actions package. Signed-off-by: Austin Vazquez <[email protected]>
ab65c4a
to
aed961a
Compare
Okay removed the code that runs the additional fuzzers. Will try to work with upstream oss_fuzz project if we can add an argument to specify the project (containerd) branch as an argument to the container image. |
/cherry-pick release/1.7 |
@AkihiroSuda: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@AkihiroSuda: new pull request created: #12099 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Related to #12007
This change removes the additional fuzzers from AdamKorcz/instrumentation repository. This is to unblock changes in containerd release/1.7 stable branch where the fuzzing workflow is failing due to compilation issues caused by higher Go toolchain requirement in mainline.