Add explicit multiport virtio-console API #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make PortDescription a struct instead of an enum with variants. This will allow for more flexibility when describing behavior of console ports. Signed-off-by: Matej Hrica <[email protected]>
mtjhrc
force-pushed
the
multiport-console-api
branch
7 times, most recently
from
6a3e3a1 to
d3c3cee
Compare
Make sure we always use the user provided descriptors instead of STDIN/STDOUT/STDERR. This behavior should be more in line with the behavior specified in the header. Signed-off-by: Matej Hrica <[email protected]>
Previosly we were assuming stdin is terminal using it to determine the terminal size. Attach a PortTerminalProperties trait object to each port for querying the correct terminal size. Note that this still only supports dynamically resizing the first port (upon SIGWINCH). Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
This restriction is actually unecessary, you can create such virtio-consoles just fine. Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
Add an example which shows the new multiport console functionality with multiple terminals. The example uses tmux to create the the terminals in the background. Signed-off-by: Matej Hrica <[email protected]>
mtjhrc
force-pushed
the
multiport-console-api
branch
from
d3c3cee to
fdca2ec
Compare
mtjhrc
requested review from
MatiasVara,
jakecorrenti,
slp and
tylerfanelli
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
krun_add_virtio_console_multiportAPI function, which attaches a blank (no ports) virtio console to the VM. To specify the ports you can use the providedkrun_add_console_port_inoutandkrun_add_console_port_tty.Apart from the
krun_add_console_port_inoutbeing necessary for Android, this also adds basic support for attaching multiple tty session to the guest (see theconsolesexample), however they have to be statically configured and opened on VM startup. In the future it should also be possible to extend the API to be able to open console ports dynamically while the VM is running (but probably libkrun 2.x).