Skip to content

e2e: add 8-socket 4k-CPU e2e vm and related test for balloons policy - #591

Merged
klihub merged 5 commits into
containers:mainfrom
askervin:5e6-e2e-balloons-4kcpu
Jan 13, 2026
Merged

klihub merged 5 commits into
containers:mainfrom
askervin:5e6-e2e-balloons-4kcpu

Conversation

@askervin

Copy link
Copy Markdown
Collaborator

Depends on

Best reviewed in separate commits. The first commit only refactors (move and rename starting with "nrt-") NRT verification functions from NRT test to a common source file. These functions are then used by the original test script and the test added here.

@askervin
askervin force-pushed the 5e6-e2e-balloons-4kcpu branch from 0b5b0bf to 6bf571e Compare November 14, 2025 13:42
Comment thread test/e2e/policies.test-suite/balloons/s8c4k/test01-sparse-4kcpus/code.var.sh Outdated
cpus-present enables creating virtual machines with different
numbers of possible and enabled CPUs. CPUs that are possible
but not enabled can be hot-plugged when the virtual machine is
running.

q35 machine, irq split and x2apic are required for hot-plugging CPUs
with id >= 256. In case of "separated_output_vars", they are now
printed in place of former "CPU:" parameter. This moves Qemu "-cpu"
parameter management to topology2qemuopts while it used to be
hardcoded "-cpu host" in Vagrantfile.in. Finally, new "SMP:" parameter
printing is added for "-smp" parameters.

Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>

@marquiz marquiz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't analyze the test case in details but looks good to me

Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
@askervin
askervin force-pushed the 5e6-e2e-balloons-4kcpu branch from 6bf571e to 5a2c5ac Compare December 19, 2025 12:21
@klihub
klihub self-requested a review January 7, 2026 08:44
@klihub

klihub commented Jan 13, 2026

Copy link
Copy Markdown
Collaborator

@marquiz Is you approval of this an implicit approval of #587, which this is stacked on ?

@marquiz marquiz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub
klihub merged commit 4eb8288 into containers:main Jan 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants