feat(cmd): podman kube play support multiple arguments #26280

axel7083 · 2025-06-04T18:26:06Z

Does this PR introduce a user-facing change?

Required for #26274

podman kube play support multiple file as arguments

openshift-ci · 2025-06-04T18:26:13Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: axel7083
Once this PR has been reviewed and has the lgtm label, please assign luap99 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

packit-as-a-service · 2025-06-11T09:47:05Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

packit-as-a-service · 2025-06-11T09:47:05Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

packit-as-a-service · 2025-06-11T09:47:05Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

axel7083 · 2025-06-11T14:13:18Z

Need rebase after

fix: absolute path usage for kube play on Windows #26352

Signed-off-by: axel7083 <[email protected]>

github-actions · 2025-07-13T00:12:29Z

A friendly reminder that this PR had no activity for 30 days.

Honny1 · 2025-10-02T18:48:49Z

@axel7083 Hope you're doing well.

Just wanted to follow up on this PR. Are you still planning to work on it? No worries if not, I can pick it up from here if needed.

Let me know! Thanks.

axel7083 · 2025-10-06T07:47:22Z

@axel7083 Hope you're doing well.

Just wanted to follow up on this PR. Are you still planning to work on it? No worries if not, I can pick it up from here if needed.

Let me know! Thanks.

Hey @Honny1,

Sorry I kinda forgot about this, I had a blocker with the tests, not able to fix them, if someone could take a look or takeover, would be lovely.

Thanks in advance

Honny1 · 2025-10-06T11:36:09Z

@axel7083 I'll investigate the problem, and then we can discuss the next steps.

Honny1

I've checked the test results, and the main problem seems to be with autocompletion. I think the other CI failures are just flakes.

I have suggested some fixes for the autocompletion issue and left a review. This change will also require a documentation update.

@axel7083 What do you think? Do you want to finish this PR, or should I take over?

Honny1 · 2025-10-08T11:22:38Z

cmd/podman/kube/play.go

 	return play(cmd, args)
 }

+func readerFromArgs(args []string) (*bytes.Reader, error) {


Nonblocking: This function could be optimized to reduce buffer operations and avoid reading whole files.

Honny1 · 2025-10-08T11:35:12Z

cmd/podman/kube/play_test.go

+			files: []string{
+				`apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: my-config`,
+			},


Nonblocking: I'm not a fan of these log strings. They visually disrupt the file's appearance. You could do something like this instead:

Suggested change

files: []string{

`apiVersion: v1

kind: ConfigMap

metadata:

name: my-config`,

},

files: []string{strings.Join([]string{

"apiVersion: v1",

"kind: ConfigMap",

"metadata:",

" name: my-config",

}, "\n"),},

Honny1 · 2025-10-08T11:43:15Z

cmd/podman/kube/play_test.go

+}
+
+func TestReaderFromArgs(t *testing.T) {
+	tests := []struct {


I see several duplicate file definitions. This could be reduced with some constants.

Honny1 · 2025-10-08T11:51:35Z

test/e2e/play_kube_test.go


+	It("all arguments should be read", func() {
+		// let's create a matrix of pod name => filename
+		pods := [][]string{


I don't think this matrix is needed. Instead, you can simply add or remove the .yaml extension from the podname.

Honny1 · 2025-10-08T11:53:08Z

test/e2e/play_kube_test.go

+		}
+
+		// run the podman command
+		kube := podmanTest.Podman(cmd)


You can use podmanTest.PodmanExitCleanly().

Honny1 · 2025-10-08T11:55:17Z

test/e2e/play_kube_test.go

+
+		// for each pods, let's ensure it has been created nicely
+		for _, test := range pods {
+			inspect := podmanTest.Podman([]string{"pod", "inspect", test[0]})


You can use podmanTest.PodmanExitCleanly() and also check the output of inspect.

Honny1 · 2025-10-08T12:02:02Z

cmd/podman/kube/down.go

 		RunE:              down,
-		Args:              cobra.ExactArgs(1),
+		Args:              cobra.MinimumNArgs(1),
 		ValidArgsFunction: common.AutocompleteDefaultOneArg,


Suggested change

ValidArgsFunction: common.AutocompleteDefaultOneArg,

ValidArgsFunction: completion.AutocompleteDefault,

Honny1 · 2025-10-08T12:02:30Z

cmd/podman/kube/play.go

 		RunE:              play,
-		Args:              cobra.ExactArgs(1),
+		Args:              cobra.MinimumNArgs(1),
 		ValidArgsFunction: common.AutocompleteDefaultOneArg,


Suggested change

ValidArgsFunction: common.AutocompleteDefaultOneArg,

ValidArgsFunction: completion.AutocompleteDefault,

Honny1 · 2025-10-08T12:02:44Z

cmd/podman/kube/play.go

 		RunE:              playKube,
-		Args:              cobra.ExactArgs(1),
+		Args:              cobra.MinimumNArgs(1),
 		ValidArgsFunction: common.AutocompleteDefaultOneArg,


Suggested change

ValidArgsFunction: common.AutocompleteDefaultOneArg,

ValidArgsFunction: completion.AutocompleteDefault,

Honny1 · 2025-10-08T12:16:57Z

test/e2e/play_kube_test.go

+		}
+
+		// prepare our podman command
+		var cmd = []string{"play", "kube"}


Suggested change

var cmd = []string{"play", "kube"}

var cmd = []string{"kube", "play"}

Honny1 · 2025-10-14T17:44:07Z

I am taking over this pull request, with the agreement of @axel7083. I have filed a new PR(#27292) to address it.

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note labels Jun 4, 2025

axel7083 force-pushed the feature/kube-play/multi-file-support branch 4 times, most recently from 6353c5a to ad961d7 Compare June 11, 2025 09:46

axel7083 force-pushed the feature/kube-play/multi-file-support branch from ad961d7 to ee57ddd Compare June 11, 2025 11:45

axel7083 mentioned this pull request Jun 11, 2025

bug(kube play): cannot use absolute path on windows #26350

Closed

axel7083 added 2 commits June 12, 2025 18:08

feat(cmd): podman kube play support multiple arguments

d10e475

Signed-off-by: axel7083 <[email protected]>

fix: update kube play command cobra use

3a509ac

Signed-off-by: axel7083 <[email protected]>

axel7083 force-pushed the feature/kube-play/multi-file-support branch from e37a183 to 3a509ac Compare June 12, 2025 16:08

axel7083 mentioned this pull request Jul 5, 2025

Kube Quadlet should support multiple YAML #26274

Open

github-actions bot added the stale-pr label Jul 13, 2025

Honny1 suggested changes Oct 8, 2025

View reviewed changes

Honny1 closed this Oct 14, 2025

-			files: []string{
-				`apiVersion: v1
-kind: ConfigMap
-metadata:
-  name: my-config`,
-			},
+			files: []string{strings.Join([]string{
+			       "apiVersion: v1",
+			       "kind: ConfigMap",
+                    "metadata:",
+                    "  name: my-config",
+			}, "\n"),},

	ValidArgsFunction: common.AutocompleteDefaultOneArg,
	ValidArgsFunction: completion.AutocompleteDefault,

	var cmd = []string{"play", "kube"}
	var cmd = []string{"kube", "play"}

feat(cmd): podman kube play support multiple arguments #26280

feat(cmd): podman kube play support multiple arguments #26280

Uh oh!

Conversation

axel7083 commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci bot commented Jun 4, 2025

Uh oh!

packit-as-a-service bot commented Jun 11, 2025

Uh oh!

packit-as-a-service bot commented Jun 11, 2025

Uh oh!

packit-as-a-service bot commented Jun 11, 2025

Uh oh!

axel7083 commented Jun 11, 2025

Uh oh!

github-actions bot commented Jul 13, 2025

Uh oh!

Honny1 commented Oct 2, 2025

Uh oh!

axel7083 commented Oct 6, 2025

Uh oh!

Honny1 commented Oct 6, 2025

Uh oh!

Honny1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Honny1 commented Oct 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

axel7083 commented Jun 4, 2025 •

edited

Loading