Skip to content

Add /var/lib/containers/storage/ to illegal mount validation. #27218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −16
Open

Add /var/lib/containers/storage/ to illegal mount validation. #27218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions docs/source/markdown/podman-machine-init.1.md.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,11 @@ options are:
* **security_model=[model]**: specify 9p security model (see below)

Note: The following destinations are forbidden for volumes: `/bin`, `/boot`, `/dev`, `/etc`,
`/home`, `/proc`, `/root`, `/run`, `/sbin`, `/sys`, `/tmp`, `/usr`, and `/var`. Subdirectories
of these destinations are allowed but users should be careful to not mount to important directories
as unexpected results may occur.
`/home`, `/proc`, `/root`, `/run`, `/sbin`, `/sys`, `/tmp`, `/usr`, and `/var`. Additionally,
`/var/lib/containers/storage` is forbidden due to virtiofs filesystem limitations that cannot
handle the multiple UIDs/GIDs required for container storage (particularly relevant on macOS and
other platforms using virtiofs). Subdirectories of these destinations are allowed but users should
be careful to not mount to important directories as unexpected results may occur.


The 9p security model [determines] https://wiki.qemu.org/Documentation/9psetup#Starting_the_Guest_directly
Expand Down
27 changes: 14 additions & 13 deletions pkg/machine/shim/host.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,19 +820,20 @@ func Reset(mps []vmconfigs.VMProvider, _ machine.ResetOptions) error {
func validateDestinationPaths(dest string) error {
// illegalMounts are locations at the / level of the podman machine where we do want users mounting directly over
illegalMounts := map[string]struct{}{
"/bin": {},
"/boot": {},
"/dev": {},
"/etc": {},
"/home": {},
"/proc": {},
"/root": {},
"/run": {},
"/sbin": {},
"/sys": {},
"/tmp": {},
"/usr": {},
"/var": {},
"/bin": {},
"/boot": {},
"/dev": {},
"/etc": {},
"/home": {},
"/proc": {},
"/root": {},
"/run": {},
"/sbin": {},
"/sys": {},
"/tmp": {},
"/usr": {},
"/var": {},
"/var/lib/containers/storage": {},
}
mountTarget := path.Clean(dest)
if _, ok := illegalMounts[mountTarget]; ok {
Expand Down
10 changes: 10 additions & 0 deletions pkg/machine/shim/host_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,16 @@ func Test_validateDestinationPaths(t *testing.T) {
dest: "/foobar",
wantErr: false,
},
{
name: "/var/lib/containers/storage/ should fail",
dest: "/var/lib/containers/storage/",
wantErr: true,
},
{
name: "/var/lib/containers/storage should fail",
dest: "/var/lib/containers/storage",
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down