Allow artifact add to override org.opencontainers.image.title annotation #27238
Conversation
|
@Luap99 PTAL |
|
An issue this introduces is when using So So we need to do something like block setting the org.opencontainers.image.title if multiple artifacts are being added in one call or maybe better yet fail if the artifact already has file/blob with the same @baude WDYT [1] https://docs.podman.io/en/v5.6.2/markdown/podman-artifact-add.1.html#annotation-annotation-value |
|
The same issue exists if you do the same name multiple times. ./bin/podman artifact add --annotation=org.opencontainers.image.title=testname multitest README.md So we can either check to see if the annotation is already defined, or just leave it to the users to deal with it. IE this is legal theoretically in the spec, so if users add it then they have to deal with it when the attempt to mount the object. |
test/e2e/artifact_test.go
Outdated
| title := RandomString(12) | ||
| annotation3 := fmt.Sprintf("org.opencontainers.image.title=%s", title) | ||
| podmanTest.PodmanExitCleanly("artifact", "add", "--annotation", annotation3, "foobar", artifact1File) | ||
| Expect(a.Manifest.Layers[0].Annotations["org.opencontainers.image.title"]).To(Equal(title)) |
There was a problem hiding this comment.
that is not checking the right thing, you need to inspect the artifact you just created with podmanTest.InspectArtifact("foobar") and use that return value to check the annotation
|
Code LGTM |
|
And Happy Green Test buttons. |
|
This is not ready yet, since we decided at the meeting today to block users from using the same title multiple times within an artifact. |
Would you mind pinging us when you have this in a state you want a review done? |
There was a problem hiding this comment.
I just merged containers/container-libs#392 so all the libartifact changes must now go there instead unfortunately
|
Ok since the contianer-libs merged you should be able to revendor that here |
Signed-off-by: Daniel J Walsh <[email protected]>
Signed-off-by: Daniel J Walsh <[email protected]>
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, ninja-quokka, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Does this PR introduce a user-facing change?