-
Notifications
You must be signed in to change notification settings - Fork 2.8k
cmd/podman: add replace flag to quadlet install #27247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nothiaki The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bcfaf04
to
e337abf
Compare
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
e337abf
to
239e701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. At first glance, I only found one issue with the bats tests. Let's see what a CI rerun will show.
Should this be renamed to |
239e701
to
ec21fba
Compare
I also think |
I am fine with naming this --replace |
893f8fe
to
ec721d6
Compare
Code LGTM. I think the test could be improved a bit to verify that it isn't appending to the existing file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. I just have one question regarding the tests.
Signed-off-by: Celso Henrique Souza Silva <[email protected]> Fixes: containers#26930
ec721d6
to
f9df00c
Compare
Fixes: #26930
Does this PR introduce a user-facing change?
Yes, this PR adds a new --replace flag to the quadlet install command.
When specified, the flag replace the installation of a Quadlet even if it already exists.
This allows users to reinstall a Quadlet without needing to manually run podman quadlet rm and podman quadlet install.