Skip to content

Conversation

nothiaki
Copy link
Contributor

@nothiaki nothiaki commented Oct 8, 2025

Fixes: #26930

Does this PR introduce a user-facing change?

Yes, this PR adds a new --replace flag to the quadlet install command.
When specified, the flag replace the installation of a Quadlet even if it already exists.

This allows users to reinstall a Quadlet without needing to manually run podman quadlet rm and podman quadlet install.

Add --replace flag to quadlet install

Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nothiaki
Once this PR has been reviewed and has the lgtm label, please assign ygalblum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nothiaki nothiaki force-pushed the quadlet-install-force branch from bcfaf04 to e337abf Compare October 8, 2025 01:34
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@nothiaki nothiaki force-pushed the quadlet-install-force branch from e337abf to 239e701 Compare October 8, 2025 14:03
Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. At first glance, I only found one issue with the bats tests. Let's see what a CI rerun will show.

@mheon
Copy link
Member

mheon commented Oct 8, 2025

Should this be renamed to --replace? Seems more obvious to me

@nothiaki nothiaki force-pushed the quadlet-install-force branch from 239e701 to ec21fba Compare October 8, 2025 19:15
@nothiaki
Copy link
Contributor Author

nothiaki commented Oct 8, 2025

Should this be renamed to --replace? Seems more obvious to me

I also think --replace would be better than --force. Once used, it wouldn't ignore any errors, it just replace the quadlet. What do you think, @Luap99?

@Luap99
Copy link
Member

Luap99 commented Oct 10, 2025

I am fine with naming this --replace

@nothiaki nothiaki force-pushed the quadlet-install-force branch 3 times, most recently from 893f8fe to ec721d6 Compare October 13, 2025 13:19
@nothiaki nothiaki changed the title cmd/podman: add force flag to quadlet install cmd/podman: add replace flag to quadlet install Oct 13, 2025
@mheon
Copy link
Member

mheon commented Oct 13, 2025

Code LGTM. I think the test could be improved a bit to verify that it isn't appending to the existing file

Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I just have one question regarding the tests.

@nothiaki nothiaki force-pushed the quadlet-install-force branch from ec721d6 to f9df00c Compare October 13, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

podman quadlet update OR podman quadlet install --force

5 participants