Podman6: Remove cgroupsv1 #27271
Draft
Podman6: Remove cgroupsv1 #27271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
lsm5
added
6.0
openshift-ci
bot
added
the
approved
|
I'd say keep this in draft until #27270 merges, then rebase ontop of that. Currently, with all the octal format changes, it's practically impossible to give the real change a review. |
|
@TomSweeneyRedHat ah i see what you mean about the reviews part. sgtm. |
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Signed-off-by: Lokesh Mandvekar <[email protected]>
Keeping SkipIfCgroupV2 and skip_if_cgroupsv2 just in case we need them in future. Signed-off-by: Lokesh Mandvekar <[email protected]>
Wherever cgroups v2 references were mentioned by name, those have been set to defaults. Signed-off-by: Lokesh Mandvekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?