Skip to content

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Oct 10, 2025

Does this PR introduce a user-facing change?

Cgroups v1 support has been removed.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note labels Oct 10, 2025
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
@lsm5 lsm5 added 6.0 Breaking changes for Podman 6.0 and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. machine release-note labels Oct 10, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
@TomSweeneyRedHat
Copy link
Member

I'd say keep this in draft until #27270 merges, then rebase ontop of that. Currently, with all the octal format changes, it's practically impossible to give the real change a review.

@lsm5
Copy link
Member Author

lsm5 commented Oct 10, 2025

I'd say keep this in draft until #27270 merges, then rebase ontop of that. Currently, with all the octal format changes, it's practically impossible to give the real change a review.

Sure, nothing's happening on this one until we branch v5.7. #27270 ideally should go into v5.7.

@lsm5
Copy link
Member Author

lsm5 commented Oct 10, 2025

@TomSweeneyRedHat ah i see what you mean about the reviews part. sgtm.

lsm5 added 3 commits October 17, 2025 15:17
Signed-off-by: Lokesh Mandvekar <[email protected]>
Keeping SkipIfCgroupV2 and skip_if_cgroupsv2 just in case we need them
in future.

Signed-off-by: Lokesh Mandvekar <[email protected]>
Wherever cgroups v2 references were mentioned by name, those have been
set to defaults.

Signed-off-by: Lokesh Mandvekar <[email protected]>
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.0 Breaking changes for Podman 6.0 approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. machine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants